Support and fix the regular constraint for MiniZinc#952
Open
hbierlee wants to merge 9 commits into
Open
Conversation
8 tasks
tias
reviewed
Jun 15, 2026
WoutPiessens
force-pushed
the
fix/support-regular-for-minizinc
branch
2 times, most recently
from
dcda911 to
65ffbf4
Compare
WoutPiessens
approved these changes
Jun 15, 2026
WoutPiessens
left a comment
WoutPiessens
left a comment
Collaborator
There was a problem hiding this comment.
The implementation looks great, one small thing: a transition dictionary object is already built in the constructor of Regular, so it can be used here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
regularconstraint was not in the support globals of MiniZinc, even though it was implemented. The implementation needed to be fixed as well. The convert_expression now can also handle strings, which are part of the MiniZinc language. Reification is not supported (https://github.com/MiniZinc/libminizinc/blob/ce06f39e8a7667721ed7410745d82e896bd9b16f/share/minizinc/std/fzn_regular_reif.mzn#L4).